remplementation of pos embedding

source/sample/transformer/T2TEmbedding.cpp

@@ -80,6 +80,17 @@ void T2TEmbedder::MakePosEmbedding(int eSize, int d, int length)
 
 
     for(int pos = 0; pos < length; pos++){
     for(int pos = 0; pos < length; pos++){
         float * dp = data + pos * eSize;
         float * dp = data + pos * eSize;
+        
+        int channelSize = eSize / 2;
+        int offset = 0;
+        for(int i = 0; i < channelSize; i++){
+            dp[offset++] = (float)sin(pos/pow(10000.0F, 2.0F*i/(d - 1)));
+        }
+        for(int i = 0; i < channelSize; i++){
+            dp[offset++] = (float)cos(pos/pow(10000.0F, 2.0F*i/(d - 1)));
+        }
+
+        /*
         for(int k = 0; k < eSize; k++){
         for(int k = 0; k < eSize; k++){
             if(k % 2 == 0){
             if(k % 2 == 0){
                 int i = k/2;
                 int i = k/2;
@@ -90,6 +101,7 @@ void T2TEmbedder::MakePosEmbedding(int eSize, int d, int length)
                 dp[k] = (float)cos(pos/pow(10000.0F, 2.0F*i/d));
                 dp[k] = (float)cos(pos/pow(10000.0F, 2.0F*i/d));
             }
             }
         }
         }
+        */
     }
     }
 
 
     posEmbeddingBase.SetData(data, posEmbeddingBase.unitNum);
     posEmbeddingBase.SetData(data, posEmbeddingBase.unitNum);